Use single random seed across embedding chunks#4492
Merged
Conversation
Shuwen-Fang
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
michelle-yooh,
richjames0,
shralex,
suexu1025,
vipannalla and
xibinliu
as code owners
July 15, 2026 21:19
Shuwen-Fang
force-pushed
the
single_random_seed
branch
from
July 15, 2026 21:21
6edc3ea to
28c7a82
Compare
NuojCheng
approved these changes
Jul 15, 2026
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Shuwen-Fang
force-pushed
the
single_random_seed
branch
from
July 16, 2026 19:10
28c7a82 to
81d3f80
Compare
PiperOrigin-RevId: 948475711
Shuwen-Fang
force-pushed
the
single_random_seed
branch
from
July 16, 2026 21:12
81d3f80 to
7819d62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use a single random seed (
rngs.params()) across all embedding chunks inRoutedMoEto ensure tokens are routed to the same destination for each chunk when random routing is enabled. This ensures tokens are routed to the same destination for each chunk, and removes unnecessary sorts across embedding chunks, reducing step time from 712 ms (xprof trace before) down to 665 ms (xprof trace after).Tests
Added
test_moe_emb_chunking_random_routingintests/unit/moe_test.pyto verify that chunked and non-chunkedRoutedMoEwith random routing produce identical outputs.Checklist