add nnx_scan util module#4507
Merged
Merged
Conversation
aireenmei
force-pushed
the
aireen/pr-nnx-scan-helper
branch
from
July 16, 2026 08:15
66cefce to
946c7cb
Compare
aireenmei
marked this pull request as ready for review
July 16, 2026 08:16
aireenmei
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025,
vipannalla and
xibinliu
as code owners
July 16, 2026 08:16
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
NuojCheng
approved these changes
Jul 16, 2026
hengtaoguo
approved these changes
Jul 16, 2026
aireenmei
force-pushed
the
aireen/pr-nnx-scan-helper
branch
from
July 16, 2026 20:09
946c7cb to
6d78811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NNXDecoder._create_scanned_layers provides a generic logic for creating scanned layers. Moving it into a separate nnx_scan util module allows re-using by other modules. Use case: Gemma4 will use a custom way to implement scannable block (in an up-coming PR), and can re-use this logic. But importing from NNXDecoder will cause circular imports. A separate nnx_scan module make the code cleaner.
Also fix a bug: jnp.moveaxis(x, scan_axis, 0) -> jnp.moveaxis(x, 0, param_scan_axis), with added unit test to guard.
Tests
Unit test
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.