Cosmos3 super reasoner - #5074
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for NVIDIA Cosmos3-Nano and Cosmos3-Super Reasoner models, including their configurations, parameter mappings, and multimodal processing logic. It also introduces output truncation upon encountering an EOS token during decoding and switches safetensor loading to recursive search. The review feedback highlights a potential bug in handling list-valued eos_token_ids, a configuration mismatch regarding tied word embeddings for the Cosmos3-Nano model, and risks associated with recursively loading safetensors from subdirectories.
lydhr
force-pushed
the
cosmos3-super-reasoner
branch
2 times, most recently
from
September 3, 2026 22:53
16453a7 to
161e435
Compare
lydhr
force-pushed
the
cosmos3-super-reasoner
branch
from
September 3, 2026 23:19
161e435 to
00aec75
Compare
lydhr
marked this pull request as ready for review
September 3, 2026 23:26
lydhr
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
September 3, 2026 23:26
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Sep 3, 2026
YixuanWang-99
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for onboarding and running inference on the NVIDIA cosmos3-super, reasoner tower.
Key updates
Reuse: It leverages the existing architectural blocks derived from Qwen3/Qwen3-VL, sharing preprocessing and attention mechanisms with the previously implemented Cosmos3-Nano variants while scaling up to a larger qwen3-vl backbone.
New components:
Fix the processor for cosmos models: the identifier should be the vision_block name rather than model name; thus the redundant explicit listing of cosmos3-xxx are removed.
Tests
Checkpoint conversion
Decoding (Robotic Arm Planning) (v6 lite)
Decoding output and analysis:
Input `<|im_start|>user <|vision_start|><|image_pad|><|vision_end|>You are a robotic arm planner. The task is to put the flower into the red bottle. Generate a detailed plan consisting of sequential subtasks to accomplish the task.<|im_end|> <|im_start|>assistant ` -> `Task Analysis:
The goal is to place the flower into the red bottle. To achieve this, we need to break down the task into a series of logical steps that the robotic arm can execute sequentially. Below is a detailed plan with explanations for each step.
Step 1: Identify and Locate the Flower
Step 2: Move the Robotic Arm to the Flower
Step 3: Grasp the Flower
Step 4: Lift the Flower
Step 5: Identify and Locate the Red Bottle
Step 6: Move the Robotic Arm to the Red Bottle
Step 7: Insert the Flower into the Red Bottle
Step 8: Release the Flower
Step 9: Verify the Task Completion
Final Answer:
The detailed plan to put the flower into the red bottle is as follows:
By following these steps sequentially, the robotic arm will successfully complete the task of placing the flower into the red bottle.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.