Add general files like pylint, gitignore, codeowners#6
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
correct codeowner Add linter check workflow
Obliviour
force-pushed
the
xpk-general-files
branch
from
0e0c4e0 to
ea63764
Compare
rwitten
approved these changes
Nov 2, 2023
ultrons
added a commit
to ultrons/xpk
that referenced
this pull request
May 4, 2026
Round-3 review AI-Hypercomputer#6/AI-Hypercomputer#7. Match parser/common.py:71's pattern: each add_argument(...).completer = X is now a single chain expression at the call site instead of going through a helper that wrapped setattr. Mypy stays clean by relaxing the parameter type on the two enclosing parser-setup functions (set_workload_delete_parser and set_workload_list_parser) to match this file's existing convention in add_shared_workload_create_required_arguments — untyped parser param so Any.add_argument().completer = X works for mypy. Removes the _set_completer wrapper, its docstring, and the typing.Any need at that boundary.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.