Xpk system files#7
Closed
Obliviour wants to merge 27 commits into
Closed
Conversation
PiperOrigin-RevId: 578374104
[xpk] Incorporate xpk into maxtext directory for open source access Tested all commands listed in the README. Run commands from maxtext home directory.
Allow kueue setup to retry up to 5 times in cluster create
Update default docker image to python:3.10 since python:3.8 is deprec…
CacheImage now explicitly selects set cluster.
Correctly error if the project name or zone name is unset
[xpk] Use kueue github repo manifest file instead of local one
* initial commit * add gke_accelerator type for v4 * remove unused import * run pylint on xpk * add command line flags * fix nits * add license * fix pylint * better function name * run pylint on all python files * support all v4 slices * remove cluster type flag * revert --cluster-type flag changes * minor fixes
Modify workload name checking to not look for prefix but match names
* [xpk] Add deletion prompt and force flag on cluster create TESTING=yes [y] checked that cluster create with deletion returns the prmpt [y] y / yes continues the prompt [y] n / no stops the deletion [y] other words stops the deletion [y] force skips the prompt * add a log message when delete is skipped. * Add pylint changes
* [xpk] Support base-docker-image and script-dir - Adds support to build local files into the docker image - Adds readme example for how to do this - Continues to support docker-image for not building local files into the image. Tested - Ran examples with local file changes - Verified that directory path has to be valid - Verified that invalid group of arguments don't work * Improve documentation and add datetime to the dockertag * Modify documentation * Additional documentation nits * docker documentation
…rom appearing when no nodepools are to be deleted. (#211) * Update Readme with clearer organization * Avoid asking delete prompt when no node pools are to be deleted
If python version is < 3.10, return error message. Tested: Yes.
* Remove unnecessary pylints and fix code lint errors * Add with commands
* Add large scale guide to xpk repository * Readme details on large scale * add details about vm size needed for different limits and spelling
PiperOrigin-RevId: 578374104
PiperOrigin-RevId: 578375588
PiperOrigin-RevId: 578684188
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ultrons
added a commit
to ultrons/xpk
that referenced
this pull request
May 4, 2026
Round-3 review AI-Hypercomputer#6/AI-Hypercomputer#7. Match parser/common.py:71's pattern: each add_argument(...).completer = X is now a single chain expression at the call site instead of going through a helper that wrapped setattr. Mypy stays clean by relaxing the parameter type on the two enclosing parser-setup functions (set_workload_delete_parser and set_workload_list_parser) to match this file's existing convention in add_shared_workload_create_required_arguments — untyped parser param so Any.add_argument().completer = X works for mypy. Removes the _set_completer wrapper, its docstring, and the typing.Any need at that boundary.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.