Skip to content

create a function to add unsupported outputs - #58

Merged
rpreen merged 7 commits into
mainfrom
unsupportedOutputs
Apr 16, 2023
Merged

create a function to add unsupported outputs#58
rpreen merged 7 commits into
mainfrom
unsupportedOutputs

Conversation

@mahaalbashir

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Apr 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #58 (106e110) into main (61bc1a1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 106e110 differs from pull request most recent head 2082816. Consider uploading reports for the commit 2082816 to get more accurate results

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   95.74%   95.79%   +0.05%     
==========================================
  Files           3        3              
  Lines         329      333       +4     
==========================================
+ Hits          315      319       +4     
  Misses         14       14              
Impacted Files Coverage Δ
acro/acro.py 96.75% <100.00%> (+0.05%) ⬆️
acro/utils.py 94.55% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mahaalbashir
mahaalbashir requested a review from rpreen April 14, 2023 13:26

@rpreen rpreen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a typo in the notebook markdown:
"Add an unssuported output to the list of outputs"... should be "unsupported"

Can we move XandY.jfif into the notebooks folder so we can keep the root folder as clean as possible?

I wonder if the custom_output() function should take in an optional string argument so a comment can be added in one go rather than having to then find the name/timestamp and subsequently call add_comment()?

Comment thread acro/acro.py Outdated
@mahaalbashir
mahaalbashir requested a review from rpreen April 16, 2023 13:46

@rpreen rpreen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; please can we remove the line on 169 and then I think this is done?

Comment thread acro/acro.py Outdated
@mahaalbashir
mahaalbashir requested a review from rpreen April 16, 2023 15:11
@rpreen
rpreen merged commit 544d42b into main Apr 16, 2023
@rpreen
rpreen deleted the unsupportedOutputs branch April 16, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create acro.custom_output(filename:string) for currently unsupported outputs

2 participants