SBRA-577 generalize the docker image build - #37
Merged
Conversation
|
Coverage report for combustion/gnns/ use-case
Minimum allowed coverage is Generated by 🐒 cobertura-action against c62acc4 |
A669015
force-pushed
the
SBRA-577-generalize-the-docker-image-build
branch
from
May 21, 2024 09:18
19d33ef to
443319a
Compare
|
Coverage report for weather_forecast/3dcorrection/unets/ use-case
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6ecf34f |
A669015
force-pushed
the
SBRA-577-generalize-the-docker-image-build
branch
5 times, most recently
from
May 21, 2024 13:46
71b728d to
c62acc4
Compare
cbovalo
approved these changes
May 21, 2024
A669015
force-pushed
the
SBRA-577-generalize-the-docker-image-build
branch
10 times, most recently
from
May 24, 2024 14:19
67d0ece to
9ba8315
Compare
|
Coverage report for combustion/gnns use-case
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7888d48 |
|
Coverage report for weather_forecast/3dcorrection/unets use-case
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7888d48 |
cbovalo
approved these changes
May 27, 2024
A669015
force-pushed
the
SBRA-577-generalize-the-docker-image-build
branch
2 times, most recently
from
May 28, 2024 08:51
d0b1d31 to
87ce573
Compare
elasto
approved these changes
May 28, 2024
A669015
force-pushed
the
SBRA-577-generalize-the-docker-image-build
branch
from
May 28, 2024 13:10
87ce573 to
84de19d
Compare
A669015
force-pushed
the
SBRA-577-generalize-the-docker-image-build
branch
from
May 28, 2024 13:32
84de19d to
7888d48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalize the way the docker images are built. It remains a single Dockerfile that is generic and that is parametrized to build the image for a given use-case.
An env.yaml file has been added, in all use-case, to define the reference environment (python, ubuntu base image) for the given use-case. This file is read by the Github action to build a docker image with the proper environment.
Some remaining tasks are postponed to avoid conflicts with the parallel job of @elasto :