Dark mode polish, colophon, favicon, emoji sweep#29
Merged
Conversation
- public/logo-dark.png: copied from design-system/brand/logo-current-dark.png. Hero renders /logo.png in light and /logo-dark.png in dark via dark:hidden / hidden dark:block sibling pair. - HeroHeadline: replace inline color: var(--gray-900) with Tailwind text-gray-900 dark:text-gray-100 so the headline is legible on both surfaces. Coral period pulled from --coral token. - Sidebar active item (dark mode): Tailwind v4's @custom-variant dark directive at the top of global.css caused raw .dark selectors there to be dropped by Lightning CSS. Move the override into docs-surface.css where the custom-variant is not declared. Rule applies color-mix(--coral 18%, transparent) and color: var(--coral) so the active leaf keeps a warm tint and pops against the near-black ground instead of reading muddy.
Footer now reads 'Whest. is built and maintained by AIcrowd and the Alignment Research Center.' with external links to aicrowd.com and alignment.org (target=_blank, rel=noreferrer noopener). Wordmark renders upright via the .whest-wordmark utility class with the coral period; surrounding prose stays in the paper-italic register.
Per /design-system/brand/logo-system.html §03 size ladder: "< 16px · dot only — the whole identity compresses to the glyph." - website/public/favicon.svg: minimal SVG, coral dot on transparent. - app/layout.tsx: icons.icon is now an array — SVG first (scales cleanly for all favicon sizes), logo.png as PNG fallback. Apple touch icon stays on the brush logo. - layout.shared.test.mjs: update favicon assertion to match the new metadata shape.
The design system permits exactly one emoji (U+2713 ✓, for copy/ confirmation affordance). Swept website/content/docs/**/*.mdx for any character in the emoji ranges (U+2300-U+23FF, U+2600-U+27BF except U+2713, U+2B00-U+2BFF, U+1F000-U+1FAFF) and removed them, normalizing the two-space artifact on heading lines. 8 files / 21 codepoints stripped. Previously-decorative heading prefixes like ✅, 🔍,⚠️ , 📎, 🟢, 🟡, 🔴 are gone. The two in-prose ✓ glyphs in contributing.mdx and flop-counting-model.mdx stay — both are load-bearing per spec voice rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up pass after the initial design-system alignment landed on
main. Four commits, all on top ofd8ef4e51:HeroHeadlinenow usestext-gray-900 dark:text-gray-100(was hard-codedvar(--gray-900), invisible on near-black). Sidebar active item in dark mode swapped fromcolor-mix(--coral-light 50%, transparent)(muddy on dark) tocolor-mix(--coral 18%, transparent)with coral text. Also vendored/logo-dark.pngfrom/design-system/brand/logo-current-dark.pngand added adark:hidden/hidden dark:blocksibling pair so the hero brush mark swaps automatically.target=_blank rel="noreferrer noopener"). Wordmark rendered via.whest-wordmark, coral period intact.public/favicon.svg(single coral#F0524Dcircle on transparent), per/design-system/brand/logo-system.html §03 size ladderwhich prescribes "< 16px · dot only" for favicons. Wired viaicons.icon = [SVG, PNG fallback]inapp/layout.tsx;logo.pngretained as the Apple touch icon.README.md §Voice) permits exactly one emoji, U+2713✓for copy/confirmation affordance; the two in-prose✓glyphs are preserved.One notable gotcha documented during this pass (recorded in
/design-system/IMPLEMENTATION_NOTES.md§20): Tailwind v4's@custom-variant dark (&:is(.dark *));directive causes Lightning CSS to silently drop raw.dark <selector>rules from any file that declares the variant. The sidebar dark override had to move out ofglobal.css(which declares the variant) intoapp/design-system/docs-surface.css.Test plan
npm --prefix website test— 82/82 pass/,/docs/getting-started/quickstart/,/docs/api/ops/histogram2d/