fix(LC0091): namespace-aware translation IDs for SDK 18.0.38.52553#391
Merged
Conversation
…8.52553 AL 18.0.38.52553 added an optional `useNamespaces` parameter to `LanguageFileUtilities.GetLanguageSymbolId` and `GetLabelTextConstLanguageSymbolId` (part of the TranslationsWithNamespaces compiler feature). C# bakes optional-parameter call sites at compile time, so the analyzer (built against the lowest net10.0 SDK and run against 18.0.38.52553 in CI) hit MissingMethodException and emitted no LC0091 — failing all 9 HasDiagnostic tests. Compute translation IDs via runtime reflection so no arity is baked into the call site: - New SDKs: internal GetTranslationFileId(...) + UseTranslationsWithNamespaces(ISymbol), producing namespace-aware trans-unit IDs that match the compiler (no false positives on namespace-enabled projects). - Older SDKs: fall back to the public 2-param methods. Add EnumProvider.SymbolKind.NamedType for the label-const path. Add version-gated (RequireMinimumVersion 18.0.38.52553) namespace regression tests that enable the feature via CompilationOptions.WithCompilerFeatures: HasDiagnostic (empty XLIFF) and NoDiagnostic (translated XLIFF with the namespace-aware ID). Update the LC0091 instruction file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extract the SDK-version-compat reflection for computing XLIFF trans-unit IDs out of the TranslatableTextShouldBeTranslated analyzer into a dedicated ALCops.Common.Reflection.TranslationIdHelper. This keeps all SDK-version-compat reflection in one place (alongside SymbolHelper, EnumProvider), so future SDK bumps only require changes in Common. The analyzer now calls TranslationIdHelper.ComputeTranslationId and retains only translation policy (which symbols to inspect, isLabelConst decisions, null-guarding). No behavior change: LC0091 tests unchanged (14 passed, 2 namespace tests skipped on SDK 18.0.36; validated green on 18.0.38.52553 previously). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With AL SDK
18.0.38.52553, 9LC0091(TranslatableTextShouldBeTranslated) tests fail — allHasDiagnostic*cases. The analyzer emits noLC0091where it should.Root cause (version drift)
LanguageFileUtilities.GetLanguageSymbolId(ISymbol, IRootTypeSymbol?)andGetLabelTextConstLanguageSymbolId(ISymbol, IRootTypeSymbol?)gained an optionalbool useNamespaces = falseparameter in18.0.38.52553(part of theTranslationsWithNamespacescompiler feature). C# bakes optional-parameter defaults into the call site at compile time. The analyzer is built once against the lowest net10.0 SDK (18.0.36.x, 2-param) and, in CI, runs against18.0.38.52553(binary reference) — so the baked 2-param overload no longer exists at runtime →MissingMethodException→ noLC0091.NoDiagnosticcases pass trivially. A localProjectReferencebuild compiles+runs against the same SDK and does not reproduce it.Fix
Translation IDs are now computed through runtime reflection so no arity is baked into the call site, and that reflection lives in a dedicated
ALCops.Common.Reflection.TranslationIdHelper(publicComputeTranslationId(ISymbol, IRootTypeSymbol?, bool isLabelConst)):GetTranslationFileId(...)+ publicUseTranslationsWithNamespaces(ISymbol). Produces namespace-aware trans-unit IDs (namespace-prefixed, unhashed segments joined by" - ", hashed only when > 400 chars) that match the compiler — avoiding false positives on namespace-enabled projects.Design split:
ALCops.Common: theLazy<MethodInfo?>probes,GetTranslationFileId/fallback branching anduseNamespacesdetection sit inTranslationIdHelper, alongsideSymbolHelper/EnumProvider— matching the project convention that all SDK-version-compat reflection is centralized in Common, so future SDK bumps only touch one place. Guarded with#if !NETSTANDARD2_1(the underlying SDK methods don't exist there; LC0091 is an inert stub on netstandard2.1).isLabelConstdecisions, null-guarding and reporting — and callsTranslationIdHelper.ComputeTranslationId(...).EnumProvider.SymbolKind.NamedTypefor the label-const path (mirrorsGetLabelTextConstLanguageSymbolId, which forcesNamedType).Tests
Added version-gated (
RequireMinimumVersion("18.0.38.52553")) namespace regression tests that enable the feature viaCompilationOptions.WithCompilerFeatures(TranslationsWithNamespaces)(resolved reflectively so the test project still compiles on older SDKs):Namespace MyCompany.App - Table MyTable - Property Caption→ no false positive.Local validation
18.0.36.33307(pinned): 262 passed, 2 namespace tests correctly skipped.18.0.38.52553(temporarily installed, then reverted): 264 passed — including both namespace tests (newGetTranslationFileIdreflection path).Cross-version coverage is handled by the CI matrix.
Docs
Updated
.github/instructions/lc0091-translatable-text-should-be-translated.instructions.md(design decisions, known issues, test coverage).Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com