fix(recipes): point at the published overlay image, not a local build name - #67
Open
jiejingzhangamd wants to merge 1 commit into
Open
fix(recipes): point at the published overlay image, not a local build name#67jiejingzhangamd wants to merge 1 commit into
jiejingzhangamd wants to merge 1 commit into
Conversation
… name examples/recipes/ referenced `rocm/infera-overlay:latest`, which is the name I built under locally. It does not exist on Docker Hub — 404 — so every recipe told the reader to deploy an image they cannot pull, and `imagePullPolicy: IfNotPresent` turns that into `manifest unknown` rather than anything that points at the cause. This is precisely the defect this branch already fixes for `rocm/infera:vllm-kimi-k3` in the Kimi-K3 page. I introduced the same one in #64 while writing the recipes. Now `inferaimage/infera-overlay:v0.2.1`, verified pullable with no credentials. The header comments carried the wrong name too and are updated with it — a stale image name in a comment misleads exactly as well as one in a field. Audited every image referenced by a manifest under examples/ and deploy/ against Docker Hub while here: inferaimage/infera-overlay:v0.2.1 ok lmsysorg/sglang:v0.5.15.post1-rocm720-mi35x ok vllm/vllm-openai-rocm:kimi-k3 ok vllm/vllm-openai-rocm:v0.25.1 ok python:3.11-slim ok infera/engine-sglang-mi300x:dev 404 The last one is in the operator's CRD samples, where a `:dev` tag reads as "your image" rather than something to pull. Left alone deliberately, noted here so it is a decision rather than an oversight. Signed-off-by: Zhang, Jiejing <jiejing.zhang@amd.com>
jiejingzhangamd
requested review from
JohnQinAMD,
limou102 and
xiaobochen-amd
as code owners
August 1, 2026 18:01
jiejingzhangamd
added a commit
that referenced
this pull request
Aug 2, 2026
Two problems, one fix. The recipes still carried 20 references to rocm/infera-overlay:latest — the name I built under locally while writing #64, which 404s on Docker Hub. #67 fixed those on a branch cut from main; this branch predates that merge and had them back. A name that only exists on one laptop keeps coming back because a tag is a promise nobody checks. And the tags that do resolve are mutable. vllm/vllm-openai-rocm:kimi-k3 was rebuilt on 2026-07-27 during this very session, which is what invalidated the "prefix caching fails engine init" note: the tag was the same and the image was not. A recipe that says "this was validated" has to name the thing that was validated. So every image is now pinned by digest: inferaimage/infera-overlay @6918eff3 (v0.2.2, this session's fixes) vllm/vllm-openai-rocm:kimi-k3 @5aa7e626 lmsysorg/sglang-rocm:...k3-20260727 @3c01f73f lmsysorg/sglang:v0.5.15...mi35x @40e940a0 Zero mutable tags remain under examples/recipes/. Each digest is one I pulled and ran, not one read off a page. All nine manifests still pass `kubectl apply --dry-run=server` against the live CRD. The readable tag is kept alongside the digest so the ref still says what it is. Signed-off-by: Zhang, Jiejing <jiejing.zhang@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/recipes/referencesrocm/infera-overlay:latest— the name I built under locally while writing #64. It does not exist on Docker Hub (404).So every recipe on
mainright now tells the reader to deploy an image they cannot pull, andimagePullPolicy: IfNotPresentturns that intomanifest unknown, which points nowhere near the cause.This is exactly the defect #65 just fixed for
rocm/infera:vllm-kimi-k3in the Kimi-K3 page. I introduced the same one next door in #64, and it missed the #65 merge by a few minutes.Now
inferaimage/infera-overlay:v0.2.1, verified pullable with no credentials. The header comments carried the wrong name too and are updated with it — a stale image name in a comment misleads exactly as well as one in a field.Audited every image reference while here
inferaimage/infera-overlay:v0.2.1lmsysorg/sglang:v0.5.15.post1-rocm720-mi35xvllm/vllm-openai-rocm:kimi-k3vllm/vllm-openai-rocm:v0.25.1python:3.11-sliminfera/engine-sglang-mi300x:devThe last is in the operator's CRD samples, where a
:devtag reads as "substitute your own image" rather than something to pull. Left alone deliberately — noted so it is a decision rather than an oversight.All eight manifests pass
kubectl apply --dry-run=serveragainst the live CRD.Worth considering separately
This is the third time an unpullable image reference has shipped — the Kimi-K3 page, these recipes, and the comments inside them — and all three were caught by someone reading, not by CI. A check that walks
image:fields inexamples/and asks the registry whether each tag exists would close the class rather than the instances. Happy to add it if you want it.🤖 Generated with Claude Code
https://claude.ai/code/session_01Pw7JSvdQb796xh5pEcctLz