Skip to content

[Tests] Unskip tests that work on rocm - #14

Merged
awelling2801 merged 5 commits into
developfrom
dev/awelling/skip_tests
Nov 19, 2025
Merged

[Tests] Unskip tests that work on rocm#14
awelling2801 merged 5 commits into
developfrom
dev/awelling/skip_tests

Conversation

@awelling2801

@awelling2801 awelling2801 commented Oct 28, 2025

Copy link
Copy Markdown

Description

The following functions are currently marked as unsupported -
format multiprocess_sparse_adam_state_dict half_spmm segment_mm gather_mm_idx_b sample_labors_prob sample_labors_noprob Bfs sparse_adam

Tested the above functions on mi300x and mi250x and also with rocm6.4.3 and rocm7.
The following functions pass and are unskipped -
multiprocess_sparse_adam_state_dict sample_labors_prob sample_labors_noprob sparse_adam sparse_adam_uva test_multiprocess_sparse_adam_state_dict

bfs passes with rocm7 but fails with rocm6.4.3 - added a condition to skip test based on rocm version

The following functions are still unsupported -
format half_spmm segment_mm gather_mm_idx_b

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • [NA] All changes have test coverage
  • [NA] Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • [NA] Related issue is referred in this PR
  • [NA] If the PR is for a new model/paper, I've updated the example index here.

@jamesETsmith jamesETsmith left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @awelling2801! Sorry it took me so long to review. When you fix the linting, this is gtg

Comment thread tests/python/common/test_traversal.py Outdated
@awelling2801
awelling2801 merged commit 9d57679 into develop Nov 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants