[Tests] Unskip tests that work on rocm - #14
Merged
Conversation
jamesETsmith
approved these changes
Nov 12, 2025
jamesETsmith
left a comment
There was a problem hiding this comment.
Thanks for doing this @awelling2801! Sorry it took me so long to review. When you fix the linting, this is gtg
GMNGeoffrey
reviewed
Nov 12, 2025
Co-authored-by: Geoffrey Martin-Noble <GMNGeoffrey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following functions are currently marked as unsupported -
format multiprocess_sparse_adam_state_dict half_spmm segment_mm gather_mm_idx_b sample_labors_prob sample_labors_noprob Bfs sparse_adamTested the above functions on mi300x and mi250x and also with rocm6.4.3 and rocm7.
The following functions pass and are unskipped -
multiprocess_sparse_adam_state_dict sample_labors_prob sample_labors_noprob sparse_adam sparse_adam_uva test_multiprocess_sparse_adam_state_dictbfspasses with rocm7 but fails with rocm6.4.3 - added a condition to skip test based on rocm versionThe following functions are still unsupported -
format half_spmm segment_mm gather_mm_idx_bChecklist
Please feel free to remove inapplicable items for your PR.