Skip to content

[Feature] Updating with Upstream - #2

Merged
jamesETsmith merged 11 commits into
developfrom
feat/jamesETsmith/bump_from_upstream
Sep 11, 2025
Merged

[Feature] Updating with Upstream#2
jamesETsmith merged 11 commits into
developfrom
feat/jamesETsmith/bump_from_upstream

Conversation

@jamesETsmith

@jamesETsmith jamesETsmith commented Aug 4, 2025

Copy link
Copy Markdown

Description

This PR updates dgl with upstream (master branch). The original PR for this (#1) got messed up when I tried to start merging in the nod-ai branch so I create a new clean branch and updated that against upstream

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Waiting on platform CI for tests

drivanov and others added 8 commits January 6, 2025 10:34
Co-authored-by: mukh1l <mmallaiy@amd.com>
Co-authored-by: awelling2801 <anuya.welling@amd.com>
Co-authored-by: Tiffany Mintz <Tiffany.Mintz@amd.com>
Co-authored-by: Vicky Tsang <vicky.tsang@amd.com>
Co-authored-by: Radha Krishna Srimanthula <radha.srimanthula@amd.com>
@jamesETsmith jamesETsmith self-assigned this Aug 4, 2025
@jamesETsmith jamesETsmith added the enhancement New feature or request label Aug 4, 2025
@jamesETsmith jamesETsmith mentioned this pull request Aug 4, 2025
2 tasks
@jamesETsmith

Copy link
Copy Markdown
Author

I looked into the github actions linting failures, e.g.

>>> Lint for examples/mxnet/gin/main.py:

  Warning (UFMT) format
    Run `lintrunner -a` to apply this patch.

    You can run `lintrunner -a` to apply this patch.

    0    |-#"Revisions Copyright Advanced Micro Devices, Inc.
    1    |-# Licensed under the Apache License Version 2.0"
       1 |+# "Revisions Copyright Advanced Micro Devices, Inc.
       2 |+# Licensed under the Apache License Version 2.0"
    3  3 | 
    4  4 | import sys
    5  5 | from parser import Parser

It's checking if the merge with the master branch will create linting failures. See these two lines in the github actions workflow.

This won't work correctly for us because we're merging into develop. My hunch is that they won't show up when we open a PR in the upstream repo.

@jamesETsmith
jamesETsmith marked this pull request as ready for review August 4, 2025 22:11
This commit also adds an include that was missing during some builds
and causing failures.
@jamesETsmith
jamesETsmith merged commit 69ceab3 into develop Sep 11, 2025
1 check failed
@jamesETsmith
jamesETsmith deleted the feat/jamesETsmith/bump_from_upstream branch September 19, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants