Skip to content

chore(lint): fix pre-commit issues; simplify linters workflow#29

Merged
diptorupd merged 2 commits into
AMD-Ecosystem:amd-integrationfrom
diptorupd:fix/pre-commit-linters
May 8, 2026
Merged

chore(lint): fix pre-commit issues; simplify linters workflow#29
diptorupd merged 2 commits into
AMD-Ecosystem:amd-integrationfrom
diptorupd:fix/pre-commit-linters

Conversation

@diptorupd

Copy link
Copy Markdown
  • Apply auto-fixes from black, clang-format, trailing-whitespace
  • Remove unused import math in python/quadrants/lang/_func_base.py
  • Drop language_version: python3.10 pins in .pre-commit-config.yaml so pre-commit uses the runner/host Python (works on 3.11+)
  • Simplify .github/workflows/linters.yml to use pre-commit/action@v3.0.1 with cached hook envs; remove obsolete scripts_new/linters.sh

…ters workflow

- Apply auto-fixes from black, clang-format, trailing-whitespace
- Remove unused `import math` in python/quadrants/lang/_func_base.py
- Drop `language_version: python3.10` pins in .pre-commit-config.yaml so
  pre-commit uses the runner/host Python (works on 3.11+)
- Simplify .github/workflows/linters.yml to use pre-commit/action@v3.0.1
  with cached hook envs; remove obsolete scripts_new/linters.sh
Comment thread .github/workflows/linters.yml Outdated
@npoulad1

npoulad1 commented May 8, 2026

Copy link
Copy Markdown

LGTM

@deepsek deepsek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for getting this resolved before it bloated!

@diptorupd
diptorupd merged commit 2856707 into AMD-Ecosystem:amd-integration May 8, 2026
3 checks passed
@diptorupd
diptorupd deleted the fix/pre-commit-linters branch May 8, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants