Skip to content

Fixup sbml testsuite gradient check#2858

Merged
FFroehlich merged 2 commits into
mainfrom
fixup_sbml_gradient_checks
Jun 30, 2025
Merged

Fixup sbml testsuite gradient check#2858
FFroehlich merged 2 commits into
mainfrom
fixup_sbml_gradient_checks

Conversation

@FFroehlich
Copy link
Copy Markdown
Member

this should have been caught the merge queue ...

@FFroehlich FFroehlich requested a review from a team as a code owner June 30, 2025 11:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.78%. Comparing base (ac676ef) to head (5cbc27d).
⚠️ Report is 76 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2858      +/-   ##
==========================================
- Coverage   80.34%   79.78%   -0.57%     
==========================================
  Files         330      330              
  Lines       22503    22503              
  Branches     1514     1514              
==========================================
- Hits        18080    17953     -127     
- Misses       4412     4539     +127     
  Partials       11       11              
Flag Coverage Δ
cpp 75.52% <ø> (+0.02%) ⬆️
cpp_python 33.72% <ø> (ø)
petab 39.25% <ø> (ø)
python 74.56% <ø> (+0.03%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good once tol_factor multiplication is fixed.

@FFroehlich FFroehlich enabled auto-merge June 30, 2025 14:29
@sonarqubecloud
Copy link
Copy Markdown

@FFroehlich FFroehlich added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 947aba7 Jun 30, 2025
45 of 46 checks passed
@dweindl dweindl deleted the fixup_sbml_gradient_checks branch July 7, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants