Skip to content

Remove MATLAB-specific model code#2957

Merged
dweindl merged 5 commits intoAMICI-dev:mainfrom
dweindl:rm_matlab_switches
Oct 3, 2025
Merged

Remove MATLAB-specific model code#2957
dweindl merged 5 commits intoAMICI-dev:mainfrom
dweindl:rm_matlab_switches

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 2, 2025

Get rid of the Python-generated code flag and any MATLAB-specific model functions.

Related to #2727.

@dweindl dweindl mentioned this pull request Oct 2, 2025
15 tasks
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 96.10895% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.43%. Comparing base (dcbbae0) to head (6ff4a21).
⚠️ Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
src/model.cpp 98.51% 2 Missing ⚠️
models/model_calvetti_py/model_calvetti_py.h 0.00% 1 Missing ⚠️
models/model_dirac_py/model_dirac_py.h 0.00% 1 Missing ⚠️
models/model_events_py/model_events_py.h 0.00% 1 Missing ⚠️
...odel_jakstat_adjoint_py/model_jakstat_adjoint_py.h 0.00% 1 Missing ⚠️
...ls/model_nested_events_py/model_nested_events_py.h 0.00% 1 Missing ⚠️
models/model_neuron_py/model_neuron_py.h 0.00% 1 Missing ⚠️
models/model_robertson_py/model_robertson_py.h 0.00% 1 Missing ⚠️
models/model_steadystate_py/model_steadystate_py.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2957      +/-   ##
==========================================
- Coverage   76.60%   76.43%   -0.17%     
==========================================
  Files         307      307              
  Lines       20134    19947     -187     
  Branches     1553     1508      -45     
==========================================
- Hits        15423    15247     -176     
+ Misses       4698     4687      -11     
  Partials       13       13              
Flag Coverage Δ
cpp 72.60% <96.10%> (+0.47%) ⬆️
cpp_python 38.17% <61.47%> (+0.25%) ⬆️
petab 39.38% <55.73%> (+0.41%) ⬆️
python 70.35% <89.88%> (+0.59%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/abstract_model.h 100.00% <ø> (ø)
include/amici/model.h 71.42% <ø> (ø)
include/amici/model_dae.h 72.72% <ø> (-2.28%) ⬇️
include/amici/model_dimensions.h 45.71% <ø> (-0.77%) ⬇️
include/amici/model_ode.h 100.00% <ø> (ø)
include/amici/model_state.h 97.11% <ø> (-0.09%) ⬇️
include/amici/serialization.h 95.17% <ø> (-0.03%) ⬇️
src/abstract_model.cpp 4.68% <ø> (+0.40%) ⬆️
src/backwardproblem.cpp 90.97% <100.00%> (+0.64%) ⬆️
src/model_dae.cpp 50.45% <100.00%> (+2.25%) ⬆️
... and 12 more

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review October 3, 2025 06:58
@dweindl dweindl requested a review from a team as a code owner October 3, 2025 06:58
@dweindl dweindl self-assigned this Oct 3, 2025
@dweindl dweindl merged commit 570c71d into AMICI-dev:main Oct 3, 2025
17 of 18 checks passed
@dweindl dweindl deleted the rm_matlab_switches branch October 3, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants