Merged
Conversation
540d485 to
8b65323
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2969 +/- ##
==========================================
- Coverage 77.29% 75.79% -1.50%
==========================================
Files 307 307
Lines 19938 19991 +53
Branches 1502 1499 -3
==========================================
- Hits 15411 15153 -258
- Misses 4514 4825 +311
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
3fd56fb to
23e7309
Compare
58a453d to
fc59680
Compare
FFroehlich
approved these changes
Oct 8, 2025
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Oct 9, 2025
Missed a few lines in AMICI-dev#2969.
Merged
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Oct 9, 2025
Missed a few lines in AMICI-dev#2969.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Oct 9, 2025
Missed a few lines in AMICI-dev#2969.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Oct 9, 2025
Missed a few lines in AMICI-dev#2969.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous mix of snake_case and camelCase was a mess. Convert everything to snake_case.
More could be done to make the API more consistent, but I'd rather get this merged asap, to avoid merge hell.
Related to #887.
Also includes: