Skip to content

snake_case#2969

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:snakecase
Oct 9, 2025
Merged

snake_case#2969
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:snakecase

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 7, 2025

The previous mix of snake_case and camelCase was a mess. Convert everything to snake_case.

More could be done to make the API more consistent, but I'd rather get this merged asap, to avoid merge hell.

Related to #887.

Also includes:

  • some minor documentation fixes
  • replacement of public data members by corresponding getters and, where relevant, setters
  • swig ignores

@dweindl dweindl added the breaking change Issue changes API in backwards-incompatible way label Oct 7, 2025
@dweindl dweindl self-assigned this Oct 7, 2025
@dweindl dweindl force-pushed the snakecase branch 5 times, most recently from 540d485 to 8b65323 Compare October 7, 2025 11:40
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 82.20742% with 187 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.79%. Comparing base (f005fac) to head (7816454).
⚠️ Report is 117 commits behind head on main.

Files with missing lines Patch % Lines
models/model_calvetti_py/main.cpp 0.00% 12 Missing ⚠️
models/model_dirac_py/main.cpp 0.00% 12 Missing ⚠️
models/model_events_py/main.cpp 0.00% 12 Missing ⚠️
models/model_jakstat_adjoint_py/main.cpp 0.00% 12 Missing ⚠️
models/model_nested_events_py/main.cpp 0.00% 12 Missing ⚠️
models/model_neuron_py/main.cpp 0.00% 12 Missing ⚠️
models/model_robertson_py/main.cpp 0.00% 12 Missing ⚠️
models/model_steadystate_py/main.cpp 0.00% 12 Missing ⚠️
src/edata.cpp 91.45% 10 Missing ⚠️
src/forwardproblem.cpp 94.79% 9 Missing ⚠️
... and 19 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2969      +/-   ##
==========================================
- Coverage   77.29%   75.79%   -1.50%     
==========================================
  Files         307      307              
  Lines       19938    19991      +53     
  Branches     1502     1499       -3     
==========================================
- Hits        15411    15153     -258     
- Misses       4514     4825     +311     
  Partials       13       13              
Flag Coverage Δ
cpp 71.96% <80.17%> (-0.82%) ⬇️
cpp_python 38.21% <34.48%> (-0.07%) ⬇️
petab 39.25% <45.63%> (-0.08%) ⬇️
python 69.53% <78.23%> (-0.81%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/abstract_model.h 100.00% <ø> (ø)
include/amici/backwardproblem.h 95.45% <100.00%> (ø)
include/amici/edata.h 100.00% <ø> (ø)
include/amici/forwardproblem.h 97.39% <100.00%> (ø)
include/amici/misc.h 91.30% <100.00%> (ø)
include/amici/model_ode.h 100.00% <ø> (ø)
include/amici/model_state.h 97.11% <100.00%> (ø)
include/amici/newton_solver.h 100.00% <ø> (ø)
include/amici/rdata.h 100.00% <100.00%> (ø)
include/amici/simulation_parameters.h 100.00% <100.00%> (ø)
... and 76 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the snakecase branch 2 times, most recently from 3fd56fb to 23e7309 Compare October 7, 2025 12:54
@dweindl dweindl marked this pull request as ready for review October 7, 2025 12:54
@dweindl dweindl requested a review from a team as a code owner October 7, 2025 12:54
@dweindl dweindl force-pushed the snakecase branch 8 times, most recently from 58a453d to fc59680 Compare October 7, 2025 15:42
@dweindl dweindl merged commit ef7f718 into AMICI-dev:main Oct 9, 2025
23 of 24 checks passed
@dweindl dweindl deleted the snakecase branch October 9, 2025 06:19
dweindl added a commit to dweindl/AMICI that referenced this pull request Oct 9, 2025
Missed a few lines in AMICI-dev#2969.
@dweindl dweindl mentioned this pull request Oct 9, 2025
dweindl added a commit to dweindl/AMICI that referenced this pull request Oct 9, 2025
Missed a few lines in AMICI-dev#2969.
dweindl added a commit to dweindl/AMICI that referenced this pull request Oct 9, 2025
Missed a few lines in AMICI-dev#2969.
dweindl added a commit to dweindl/AMICI that referenced this pull request Oct 9, 2025
Missed a few lines in AMICI-dev#2969.
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2025
Missed a few lines in #2969.
dweindl added a commit that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Issue changes API in backwards-incompatible way

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants