Repository navigation
Oustanding Improvements
Anuj Gupta edited this page Oct 23, 2026
·
10 revisions
This is a list of code quality improvements that aren't bugs, but have been highlighted during code review and are considered high priority for improving quality of the code-base. For issues that could cause crashes or invalid output, please instead use Known Bugs.
| Added On | Resolved by PR# | Affected ToolChains | Affected Tools | Description |
|---|---|---|---|---|
| 2026-10-21 | All | Many | Define Classes in DataModel directory to encapsulate groups of variables related to common features, providing features for resetting, populating and retreiving in ANNIEEvent, and setting variables attached to ROOT TTrees | |
| 2026-10-21 | LAPPD ToolChains | Many | Remove, update, or explicitly remark Tools and ToolChains that are no longer supported and incompatible with current (dual-ACDC) event-building. | |
| 2026-10-21 | All | PMTDataDecoder, LoadGeometry | The BRF/RWM/BES channels are hard-coded in PMTDataDecoder and are run-dependent. AuxChannels.csv can't hold run-dependent mappings, so LoadGeometry needs to support several mapping files selected by run number. |
|
| 2026-10-24 | EBSaver, LAPPDLoadStore | Many cout/cerr present. Convert to Log(...). |
||
| 2026-10-24 | EventBuilderV2, BeamClusterAnalysis | PMTDataDecoder, EBPMT, EBSaver, FitRWMWaveform | RWM, BRF and BES handling is copied three times in each tool. Use one helper. | |
| 2026-10-24 | Many | Many | Magic numbers used, update to use named constants. | |
| 2026-10-24 | BeamClusterAnalysis | None | Remove config.py and configLAPPD.py from the mentioned ToolChain and update autoANNIE scripts. Such python scripts do not belong to ToolAnalysis. |
|
| 2026-10-24 | EventBuilderV2 (all) | EBSaver | Use pointer for large objects, like RawWaveformMap. |