Skip to content

Conversation

@wep21
Copy link
Collaborator

@wep21 wep21 commented Apr 13, 2021

This PR contains

fmrico and others added 6 commits April 14, 2021 01:56
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Copy link

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but CI also isn't passing.

--skip-keys "pybind11_vendor" --skip-keys "ompl" --skip-keys "slam_toolbox" --skip-keys "octomap" --from-paths src
colcon build --symlink-install --parallel-workers 1 --packages-up-to \
pcl_ros
pcl_ros octomap_msgs nav2_msgs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the dependency on nav2_msgs?

Copy link
Collaborator Author

@wep21 wep21 Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nav2_costmap_2d deprends on nav2_msgs and grid_map_costmap_2d depends on nav2_costmap_2d. CI always fails when building nav2_costmap_2d, but I don't know why...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the reason is a lack of resource.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveMacenski Could you make circleci timeout longer?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.

That's not a timeout, that's a lack of available memory on the container

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveMacenski Thank you for configuring CircleCI.
By the way, is it better to create foxy branch because some components of foxy is not compatible with those of rolling?
Are you working on binary release for now? #268

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done - foxy-devel added

I'm not working on a binary release right now, I think its blocked by other dependencies unreleased if memory serves

@SteveMacenski SteveMacenski mentioned this pull request Apr 13, 2021
@wep21 wep21 force-pushed the rolling branch 2 times, most recently from d4036e4 to f832a57 Compare April 13, 2021 20:14
wep21 added 2 commits April 14, 2021 05:24
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 force-pushed the rolling branch 10 times, most recently from a08f67c to 3f90dee Compare April 14, 2021 16:53
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@SteveMacenski SteveMacenski merged commit c5d985a into ANYbotics:ros2 May 20, 2021
@wep21 wep21 deleted the rolling branch May 21, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants