- 
                Notifications
    
You must be signed in to change notification settings  - Fork 842
 
Update for rolliing #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for rolliing #296
Conversation
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but CI also isn't passing.
        
          
                .circleci/config.yml
              
                Outdated
          
        
      | --skip-keys "pybind11_vendor" --skip-keys "ompl" --skip-keys "slam_toolbox" --skip-keys "octomap" --from-paths src | ||
| colcon build --symlink-install --parallel-workers 1 --packages-up-to \ | ||
| pcl_ros | ||
| pcl_ros octomap_msgs nav2_msgs | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the dependency on nav2_msgs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nav2_costmap_2d deprends on nav2_msgs and grid_map_costmap_2d depends on nav2_costmap_2d. CI always fails when building nav2_costmap_2d, but I don't know why...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the reason is a lack of resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SteveMacenski Could you make circleci timeout longer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
That's not a timeout, that's a lack of available memory on the container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SteveMacenski Thank you for configuring CircleCI.
By the way, is it better to create foxy branch because some components of foxy is not compatible with those of rolling?
Are you working on binary release for now? #268
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done - foxy-devel added
I'm not working on a binary release right now, I think its blocked by other dependencies unreleased if memory serves
d4036e4    to
    f832a57      
    Compare
  
    Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
a08f67c    to
    3f90dee      
    Compare
  
    Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
This PR contains