fix(slnx): load Samples.Diagnostics as a project, excluded from solution build#189
Merged
Conversation
…ion build The Diagnostics sample was added to ErrorOrX.slnx as loose <File> items (including its .csproj), so IDEs showed the files without project context and no EOE analyzer/generator squiggles appeared. Replace them with a proper <Project> entry using <Build Solution="*|*" Project="false" /> so the project loads for IDE analysis but 'dotnet build ErrorOrX.slnx' still skips it (its build fails by design — 7 EOE diagnostics as errors). Verified: solution build green (0 warnings/0 errors); explicit project build still fires EOE003/004/006/007/020/021/024. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Diagnostics sample had been added to
ErrorOrX.slnxas loose<File>items (including its.csprojas a plain file), so IDEs loaded the files without any project context — no EOE analyzer/generator squiggles appeared. This replaces them with a proper<Project>entry excluded from the solution build:The project now loads in the IDE for live diagnostics, while
dotnet build ErrorOrX.slnxstill skips it (its build fails by design — seven EOE diagnostics reported as errors). Also updates the Diagnostics README, which claimed the project was excluded from the slnx entirely.Verification
dotnet build ErrorOrX.slnx→ Build succeeded, 0 Warning(s), 0 Error(s)dotnet build samples/ErrorOrX.Samples.Diagnostics/→ fails as intended, firing EOE003, EOE004, EOE006, EOE007, EOE020, EOE021, EOE024Status: complete-and-verified. No package content changed — no release needed.
🤖 Generated with Claude Code