fix(settings): wire the three Appearance settings that never reached the UI - #274
Merged
Conversation
…the UI Theme and accent worked. The other three did not, and Font Size was worse than merely unwired. Font Size. `--base-font-size` does land on <html>, so rem utilities scale correctly. But 247 arbitrary `text-[Npx]` values across 63 files are absolute and never move. At "small" that inverts the hierarchy: the root drops to 12px so `text-sm` renders 10.5px, while a caption pinned at 11px stays 11px and comes out larger than the body text it sits under. The scale in use was nine tiers inside 6px (8, 9, 10, 10.5, 11, 12, 12.25, 13, 14) — noise, not a hierarchy. It is now four rem steps. Tailwind stops at `xs`, so `--text-2xs` joins the `@theme` block for badges and count bubbles; 8/9px collapse into it, 10/11px into `text-xs`, 12/13px into `text-sm`. At the default size nothing moves more than 0.75px, and every step now tracks the setting. `scripts/check-type-scale.js` fails CI on the next absolute font size, so this doesn't silently accumulate again. Card Density and Animation Speed were fully inert. The chain ran store → data attribute → CSS var → `.card-padding` / `.card-gap` / `.transition-appearance` and died at the last hop: those three helper classes were used by zero components. Density now drives the task card's padding and the column's inter-card gap directly, at the call site where the dependency is visible. Animation Speed rides Tailwind's own `--default-transition-duration`, so every `transition-*` utility honours it without each component remembering to opt in. The three dead classes are deleted. Measured in a real browser, not inferred — small/medium/large now give 12/14/16px root with the full scale tracking, density 7/10.5/14px padding, and transitions 0/75/150ms. Framer Motion still ignores Animation Speed; noted on the roadmap. Adds appearance.test.ts, which pins the half jsdom can check: every value has to land on <html>, since that is what index.css selects on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap Important #2. Theme and accent colour worked; the other three Appearance settings did not.
Font Size — was worse than unwired
--base-font-sizedoes reach<html>, so rem utilities scale. But 247 arbitrarytext-[Npx]values across 63 files are absolute and never move. At "small" that inverts the hierarchy: the root drops to 12px sotext-smrenders 10.5px, while a caption pinned at 11px stays 11px and comes out larger than the body text it sits under.Measured in a real browser, before:
htmltext-smtext-xstext-[11px]The scale in use was nine tiers inside 6px — 8, 9, 10, 10.5, 11, 12, 12.25, 13, 14. That is noise, not a hierarchy. It is now four rem steps:
text-2xstext-xstext-smtext-baseTailwind stops at
xs, so--text-2xsjoins the@themeblock. 8/9px collapse into it, 10/11px intotext-xs, 12/13px intotext-sm. At the default size nothing moves more than 0.75px, and every step now tracks the setting.scripts/check-type-scale.jsfails CI on the next absolute font size, so this can't silently accumulate again (wired into bothci.ymlandrelease.yml).Card Density and Animation Speed — fully inert
The chain ran store → data attribute → CSS var →
.card-padding/.card-gap/.transition-appearance, and died at the last hop: those three helper classes were used by zero components.p-3=--card-paddingcomfortable), so nothing shifts at the default.--default-transition-duration, so everytransition-*utility in the app honours it without opting in.Verified in the browser, not inferred
text-sm→text-2xstransition-colorsChecked visually on the board at "small": the card title is now unambiguously the largest element, where before the meta row and branch rendered larger than the description above them.
Known gap
Framer Motion animations still ignore Animation Speed — they read no CSS variable, so "none" doesn't fully mean none. Noted on the roadmap rather than fixed here.
Checks
tsc --noEmit·eslint·test:ipc·test:type-scale·vitest434 passed (+5 newappearance.test.ts) ·vite build·pnpm audit. No Rust touched.