create header component and use Outfit font - #4
Closed
elijah-wright wants to merge 1 commit into
Closed
Conversation
alexng353
requested changes
Apr 14, 2024
| @@ -0,0 +1,69 @@ | |||
| 'use client'; | |||
| import NextLink from 'next/link'; | |||
Contributor
There was a problem hiding this comment.
By convention, can we keep imports from next/link as Link or use the named export (which is also called Link)
| return ( | ||
| <html lang="en"> | ||
| <body className={`font-sans ${inter.variable}`}> | ||
| <body className={`font-sans ${outfit.variable}`}> |
Contributor
There was a problem hiding this comment.
I'm going to install clsx in the repository, so this will be dated soon.
Collaborator
Author
There was a problem hiding this comment.
for the time being, we can use this
Contributor
|
One of the things I also want to be built into the site from the start is dark/light mode accessibility and other accessibility features. They aren't something that should be added later as an afterthought. I must read more on this, but I'll develop something as part of Also, this likely won't be merged for the foreseeable future since the application is largely not set up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes made per Figma. to be discussed before merging