Skip to content

Overload __str__ #53#58

Merged
guilyx merged 4 commits intomainfrom
enhance-output
Jan 4, 2021
Merged

Overload __str__ #53#58
guilyx merged 4 commits intomainfrom
enhance-output

Conversation

@sampreets3
Copy link
Copy Markdown
Member

@sampreets3 sampreets3 commented Dec 23, 2020

Closes #53

@sampreets3 sampreets3 requested a review from guilyx December 23, 2020 11:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2020

Codecov Report

Merging #58 (dcf9e13) into main (1f40c6a) will increase coverage by 0.27%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   93.47%   93.75%   +0.27%     
==========================================
  Files          17       18       +1     
  Lines         966     1008      +42     
==========================================
+ Hits          903      945      +42     
  Misses         63       63              
Impacted Files Coverage Δ
jupyddl/data_analyst.py 88.19% <ø> (ø)
jupyddl/heuristics.py 90.69% <0.00%> (ø)
tests/test_automated_planner.py 100.00% <ø> (ø)
tests/test_basic_search.py 100.00% <ø> (ø)
jupyddl/automated_planner.py 94.87% <93.33%> (+0.42%) ⬆️
jupyddl/node.py 97.82% <100.00%> (+1.15%) ⬆️
tests/test_dfs.py 100.00% <100.00%> (ø)
tests/test_node.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39d17b...dcf9e13. Read the comment docs.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 23, 2020

This pull request is now in conflicts. Could you fix it @sampreets3? 🙏

@sampreets3
Copy link
Copy Markdown
Member Author

@guilyx Just check whether this commit still holds, if not then just delete the branch. I cannot seem to find the way to do so

@sampreets3
Copy link
Copy Markdown
Member Author

This branch seems to not be of any use anymore, as the logging has changed. I suppose we can delete this branch, and it would not have a bad effect.

@guilyx
Copy link
Copy Markdown
Member

guilyx commented Dec 23, 2020 via email

@guilyx guilyx added the enhancement New feature or request label Dec 23, 2020
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 24, 2020

This pull request is now in conflicts. Could you fix it @sampreets3? 🙏

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 28, 2020

This pull request is now in conflicts. Could you fix it @sampreets3? 🙏

@guilyx guilyx changed the title Fix Issue #53 Overload __str__ #53 Dec 28, 2020
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 1, 2021

This pull request is now in conflicts. Could you fix it @sampreets3? 🙏

@guilyx guilyx merged commit 7f83a21 into main Jan 4, 2021
@mergify mergify Bot deleted the enhance-output branch January 4, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package the output into a more readable format

2 participants