docs(pong): document valid port range (1-65535) for Property.port and Peer.port - #57
Merged
Merged
Conversation
Contributor
Author
|
@VasilevNStas Thanks for the contribution! You've earned +8 points for this: +16 as a basis; -8 for too few (6) hits-of-code. Please, keep them coming. Your running score is +84; don't forget to check your Zerocracy account too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents the valid TCP port range (1–65535) for both
Property.portandPeer.port. No wire changes.Problem
Both port fields are
uint32(proto3 has no uint16), accepting values up to 4,294,967,295. A value above 65535 causes the client TCP dial to fail with a platform-specific "invalid port" error. Without documented bounds, neither the Hub nor the Node has a spec-level signal to reject out-of-range values.Changes
Property.port: added "Valid range 1–65535; the Hub and Node MUST reject values outside this range."Peer.port: added "Valid range 1–65535; the Hub MUST reject values outside this range."Closes #28