fix(core-transaction-pool): pass correct transaction data#1564
Merged
faustbrian merged 1 commit intoArkEcosystem:developfrom Dec 4, 2018
spkjp:fix-tx-apply
Merged
fix(core-transaction-pool): pass correct transaction data#1564faustbrian merged 1 commit intoArkEcosystem:developfrom spkjp:fix-tx-apply
faustbrian merged 1 commit intoArkEcosystem:developfrom
spkjp:fix-tx-apply
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1564 +/- ##
===========================================
+ Coverage 74.75% 74.87% +0.12%
===========================================
Files 439 439
Lines 7894 7894
Branches 1038 1038
===========================================
+ Hits 5901 5911 +10
+ Misses 1770 1763 -7
+ Partials 223 220 -3
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Passing
transactiontowallet.canApplyis wrong, as the timestamp is modified by the Block constructor to match its own timestamp. We need to passtransaction.dataas we only have here the unmodified timestamp which was used to calculate the signature(s).Second signature transactions no longer cause a double spend error.
Types of changes
Checklist