Skip to content

feat(core-api): allow block display via height in v2 API#1626

Merged
faustbrian merged 2 commits intodevelopfrom
block-height
Dec 4, 2018
Merged

feat(core-api): allow block display via height in v2 API#1626
faustbrian merged 2 commits intodevelopfrom
block-height

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

Proposed changes

Allows to display blocks via http://localhost:4003/api/v2/blocks/14367 based on a height to remove the need to know the block ID.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from spkjp December 4, 2018 08:21
@ghost ghost assigned faustbrian Dec 4, 2018
@ghost ghost added the review label Dec 4, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 4, 2018

Codecov Report

Merging #1626 into develop will increase coverage by 0.12%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1626      +/-   ##
===========================================
+ Coverage    74.75%   74.87%   +0.12%     
===========================================
  Files          439      439              
  Lines         7894     7896       +2     
  Branches      1038     1039       +1     
===========================================
+ Hits          5901     5912      +11     
+ Misses        1770     1764       -6     
+ Partials       223      220       -3
Impacted Files Coverage Δ
packages/core-api/lib/repositories/blocks.js 88.09% <50%> (-1.91%) ⬇️
...p2p/lib/server/versions/internal/handlers/utils.js 86.66% <0%> (+6.66%) ⬆️
packages/core-forger/lib/manager.js 80.58% <0%> (+8.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867d9ea...b86fa0b. Read the comment docs.

@faustbrian faustbrian merged commit c912546 into develop Dec 4, 2018
@ghost ghost removed the review label Dec 4, 2018
@faustbrian faustbrian deleted the block-height branch December 4, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants