perf(core-database-postgres): add sender&receiver indexes#1638
Merged
faustbrian merged 1 commit intodevelopfrom Dec 4, 2018
Merged
perf(core-database-postgres): add sender&receiver indexes#1638faustbrian merged 1 commit intodevelopfrom
faustbrian merged 1 commit intodevelopfrom
Conversation
Add indexes on transactions's sender_public_key and recipient_id columns. Impact on queries: SELECT count(*) AS count FROM transactions WHERE sender_public_key = '... many matches ...' OR recipient_id = '... many matches ...'; ~230ms -> 230ms (no change) SELECT count(*) AS count FROM transactions WHERE sender_public_key = '... many matches ...' OR recipient_id = '... few matches ...'; ~230ms -> 90ms SELECT count(*) AS count FROM transactions WHERE sender_public_key = '... few matches ...' OR recipient_id = '... many matches ...'; ~230ms -> 70ms SELECT count(*) AS count FROM transactions WHERE sender_public_key = '... few matches ...' OR recipient_id = '... few matches ...'; ~230ms -> 50ms
0227202 to
eda7e6d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1638 +/- ##
===========================================
- Coverage 74.87% 74.74% -0.13%
===========================================
Files 439 439
Lines 7896 7896
Branches 1039 1039
===========================================
- Hits 5912 5902 -10
- Misses 1764 1771 +7
- Partials 220 223 +3
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add indexes on transactions's sender_public_key and recipient_id
columns.
Impact on queries:
SELECT count(*) AS count FROM transactions WHERE
sender_public_key = '... many matches ...' OR
recipient_id = '... many matches ...';
~230ms -> 230ms (no change)
SELECT count(*) AS count FROM transactions WHERE
sender_public_key = '... many matches ...' OR
recipient_id = '... few matches ...';
~230ms -> 90ms
SELECT count(*) AS count FROM transactions WHERE
sender_public_key = '... few matches ...' OR
recipient_id = '... many matches ...';
~230ms -> 70ms
SELECT count(*) AS count FROM transactions WHERE
sender_public_key = '... few matches ...' OR
recipient_id = '... few matches ...';
~230ms -> 50ms
Proposed changes
Types of changes
Checklist