fix(core-api): ensure safe integer range for block height lookups#1673
Merged
faustbrian merged 3 commits intodevelopfrom Dec 7, 2018
Merged
fix(core-api): ensure safe integer range for block height lookups#1673faustbrian merged 3 commits intodevelopfrom
faustbrian merged 3 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1673 +/- ##
===========================================
+ Coverage 74.96% 75.09% +0.12%
===========================================
Files 444 444
Lines 7961 7962 +1
Branches 1048 1048
===========================================
+ Hits 5968 5979 +11
+ Misses 1770 1763 -7
+ Partials 223 220 -3
Continue to review full report at Codecov.
|
spkjp
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
We store heights as integers in postgresql which can cause issues when block IDs are tried as heights as the max allowed size is 2147483647.
Types of changes
Checklist