Skip to content

fix(core-p2p): malformed condition for filtering peers#1689

Merged
faustbrian merged 2 commits intodevelopfrom
fix-peers-filtering
Dec 14, 2018
Merged

fix(core-p2p): malformed condition for filtering peers#1689
faustbrian merged 2 commits intodevelopfrom
fix-peers-filtering

Conversation

@vasild
Copy link
Copy Markdown
Contributor

@vasild vasild commented Dec 10, 2018

Currently we would leave in the list all peers that:
"are not me or have invalid port or have invalid version"
the intention must have been:
"are not me and have valid port and have valid version".

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Currently we would leave in the list all peers that:
"are not me or have invalid port or have invalid version"
the intention must have been:
"are not me and have valid port and have valid version".
@ghost ghost assigned vasild Dec 10, 2018
@ghost ghost added the review label Dec 10, 2018
@faustbrian
Copy link
Copy Markdown
Contributor

@vasild This can now be adjusted to TypeScript on the develop branch so we can include it in the next release.

faustbrian
faustbrian previously approved these changes Dec 13, 2018
Copy link
Copy Markdown
Contributor

@faustbrian faustbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the conflicts are resolved.

@faustbrian faustbrian merged commit 0c23196 into develop Dec 14, 2018
@faustbrian faustbrian deleted the fix-peers-filtering branch December 14, 2018 03:33
@ghost ghost removed the review label Dec 14, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 14, 2018

Codecov Report

Merging #1689 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1689      +/-   ##
===========================================
+ Coverage    39.41%   39.41%   +<.01%     
===========================================
  Files          353      353              
  Lines         7675     7674       -1     
  Branches      1076     1091      +15     
===========================================
  Hits          3025     3025              
+ Misses        4636     4633       -3     
- Partials        14       16       +2
Impacted Files Coverage Δ
packages/core-p2p/src/monitor.ts 0% <0%> (ø) ⬆️
packages/core-deployer/src/utils.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f320c4...2aa2868. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants