fix(core-p2p): malformed condition for filtering peers#1689
Merged
faustbrian merged 2 commits intodevelopfrom Dec 14, 2018
Merged
fix(core-p2p): malformed condition for filtering peers#1689faustbrian merged 2 commits intodevelopfrom
faustbrian merged 2 commits intodevelopfrom
Conversation
Currently we would leave in the list all peers that: "are not me or have invalid port or have invalid version" the intention must have been: "are not me and have valid port and have valid version".
Contributor
|
@vasild This can now be adjusted to TypeScript on the |
faustbrian
previously approved these changes
Dec 13, 2018
Contributor
faustbrian
left a comment
There was a problem hiding this comment.
Looks good once the conflicts are resolved.
faustbrian
approved these changes
Dec 14, 2018
Codecov Report
@@ Coverage Diff @@
## develop #1689 +/- ##
===========================================
+ Coverage 39.41% 39.41% +<.01%
===========================================
Files 353 353
Lines 7675 7674 -1
Branches 1076 1091 +15
===========================================
Hits 3025 3025
+ Misses 4636 4633 -3
- Partials 14 16 +2
Continue to review full report at Codecov.
|
faustbrian
added a commit
that referenced
this pull request
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we would leave in the list all peers that:
"are not me or have invalid port or have invalid version"
the intention must have been:
"are not me and have valid port and have valid version".
Proposed changes
Types of changes
Checklist