Skip to content

fix(core-api): pagination schema#1717

Merged
faustbrian merged 2 commits intoArkEcosystem:developfrom
spkjp:fix-pagination-schema
Dec 14, 2018
Merged

fix(core-api): pagination schema#1717
faustbrian merged 2 commits intoArkEcosystem:developfrom
spkjp:fix-pagination-schema

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented Dec 13, 2018

Proposed changes

Fixes #1714

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested a review from faustbrian December 13, 2018 20:01
@ghost ghost assigned spkjp Dec 13, 2018
@ghost ghost added the review label Dec 13, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 13, 2018

Codecov Report

Merging #1717 into develop will decrease coverage by 0.66%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1717      +/-   ##
===========================================
- Coverage    40.08%   39.41%   -0.67%     
===========================================
  Files          363      353      -10     
  Lines         8211     7675     -536     
  Branches      1186     1108      -78     
===========================================
- Hits          3291     3025     -266     
+ Misses        4901     4634     -267     
+ Partials        19       16       -3
Impacted Files Coverage Δ
packages/core-api/src/versions/2/wallets/schema.ts 0% <0%> (ø) ⬆️
...ckages/core-api/src/versions/2/delegates/schema.ts 0% <0%> (ø) ⬆️
...ges/core-api/src/versions/2/transactions/schema.ts 0% <0%> (ø) ⬆️
packages/core-api/src/versions/2/votes/schema.ts 0% <0%> (ø) ⬆️
packages/core-api/src/versions/2/blocks/schema.ts 0% <0%> (ø) ⬆️
packages/core-api/src/versions/2/peers/schema.ts 0% <0%> (ø) ⬆️
packages/core-deployer/src/utils.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 0% <0%> (ø) ⬆️
packages/core-snapshots/src/defaults.ts
...es/core-tester-cli/src/commands/multi-signature.ts
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452f96b...dfb98f0. Read the comment docs.

@faustbrian faustbrian merged commit 9f320c4 into ArkEcosystem:develop Dec 14, 2018
@ghost ghost removed the review label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants