refactor: split config into network, milestones, exceptions and dynamic-fees#1733
Merged
faustbrian merged 68 commits intodevelopfrom Dec 17, 2018
Merged
refactor: split config into network, milestones, exceptions and dynamic-fees#1733faustbrian merged 68 commits intodevelopfrom
faustbrian merged 68 commits intodevelopfrom
Conversation
added 20 commits
December 15, 2018 06:35
Codecov Report
@@ Coverage Diff @@
## develop #1733 +/- ##
===========================================
- Coverage 39.9% 39.76% -0.15%
===========================================
Files 352 354 +2
Lines 7685 7682 -3
Branches 1098 1106 +8
===========================================
- Hits 3067 3055 -12
- Misses 4603 4613 +10
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
added 6 commits
December 15, 2018 13:47
Contributor
Author
|
@supaiku0 should be ready for review for now. A lot of changes were made some in preparation for hot reloading to make it easier. |
spkjp
approved these changes
Dec 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Sorts out the mess the whole configuration is at the moment by splitting it into network, fees and milestones. This means people no longer need to update their network config anymore.
Dynamic fees are specific to nodes and should not be included in milestones.
Types of changes
Checklist