fix(core-database): ensure that delegate search deals with "undefined" as username#1831
Merged
faustbrian merged 5 commits intodevelopfrom Dec 18, 2018
Merged
fix(core-database): ensure that delegate search deals with "undefined" as username#1831faustbrian merged 5 commits intodevelopfrom
faustbrian merged 5 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1831 +/- ##
===========================================
+ Coverage 39.68% 39.73% +0.05%
===========================================
Files 354 354
Lines 7691 7693 +2
Branches 1086 1113 +27
===========================================
+ Hits 3052 3057 +5
+ Misses 4627 4622 -5
- Partials 12 14 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
Other search endpoints return all the results when no parameter is passed, so I've updated this fix to make it consistent |
faustbrian
approved these changes
Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Searching delegates without parameters return the delegate with username "undefined" when it should not return anything.
Types of changes
Checklist