Skip to content

fix: check semver validity#1836

Merged
faustbrian merged 2 commits intoArkEcosystem:developfrom
spkjp:check-semver
Dec 18, 2018
Merged

fix: check semver validity#1836
faustbrian merged 2 commits intoArkEcosystem:developfrom
spkjp:check-semver

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented Dec 17, 2018

Proposed changes

Instead of throwing a TypeError return false if the version is invalid.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested a review from faustbrian December 17, 2018 23:54
@ghost ghost assigned spkjp Dec 17, 2018
@ghost ghost added the review label Dec 17, 2018
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1836 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1836      +/-   ##
===========================================
- Coverage    39.76%   39.75%   -0.02%     
===========================================
  Files          354      354              
  Lines         7682     7684       +2     
  Branches      1121     1084      -37     
===========================================
  Hits          3055     3055              
- Misses        4612     4617       +5     
+ Partials        15       12       -3
Impacted Files Coverage Δ
packages/core-p2p/src/court/guard.ts 0% <0%> (ø) ⬆️
packages/core-deployer/src/utils.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 85.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a76d4c...81b7d73. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 17, 2018

Codecov Report

Merging #1836 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1836      +/-   ##
===========================================
- Coverage    39.73%   39.72%   -0.02%     
===========================================
  Files          354      354              
  Lines         7689     7691       +2     
  Branches      1117     1095      -22     
===========================================
  Hits          3055     3055              
- Misses        4619     4621       +2     
  Partials        15       15
Impacted Files Coverage Δ
packages/core-p2p/src/court/guard.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3674423...ab0b8b5. Read the comment docs.

@ghost ghost assigned faustbrian Dec 18, 2018
@faustbrian faustbrian merged commit aff9c15 into ArkEcosystem:develop Dec 18, 2018
@ghost ghost removed the review label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants