Skip to content

feat(core-p2p): milestone hash#1837

Merged
faustbrian merged 3 commits intoArkEcosystem:developfrom
spkjp:milestone-hash
Dec 18, 2018
Merged

feat(core-p2p): milestone hash#1837
faustbrian merged 3 commits intoArkEcosystem:developfrom
spkjp:milestone-hash

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented Dec 18, 2018

Proposed changes

Reject peers with a different milestone hash.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested a review from faustbrian December 18, 2018 02:57
@ghost ghost assigned spkjp Dec 18, 2018
@ghost ghost added the review label Dec 18, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 18, 2018

Codecov Report

Merging #1837 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1837      +/-   ##
===========================================
- Coverage    39.76%   39.73%   -0.04%     
===========================================
  Files          354      354              
  Lines         7682     7689       +7     
  Branches      1121     1114       -7     
===========================================
  Hits          3055     3055              
- Misses        4612     4620       +8     
+ Partials        15       14       -1
Impacted Files Coverage Δ
packages/core-p2p/src/court/offences.ts 100% <ø> (ø) ⬆️
packages/core-p2p/src/court/guard.ts 0% <0%> (ø) ⬆️
packages/core-p2p/src/peer.ts 0% <0%> (ø) ⬆️
packages/core-blockchain/src/state-machine.ts 42.92% <0%> (ø) ⬆️
...ackages/core-p2p/src/server/plugins/set-headers.ts 0% <0%> (ø) ⬆️
packages/core-p2p/src/monitor.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 85.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a76d4c...10b65f0. Read the comment docs.

@faustbrian faustbrian merged commit 3674423 into ArkEcosystem:develop Dec 18, 2018
@ghost ghost removed the review label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants