feat(core-p2p): milestone hash#1837
Merged
faustbrian merged 3 commits intoArkEcosystem:developfrom Dec 18, 2018
spkjp:milestone-hash
Merged
feat(core-p2p): milestone hash#1837faustbrian merged 3 commits intoArkEcosystem:developfrom spkjp:milestone-hash
faustbrian merged 3 commits intoArkEcosystem:developfrom
spkjp:milestone-hash
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1837 +/- ##
===========================================
- Coverage 39.76% 39.73% -0.04%
===========================================
Files 354 354
Lines 7682 7689 +7
Branches 1121 1114 -7
===========================================
Hits 3055 3055
- Misses 4612 4620 +8
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Reject peers with a different milestone hash.
Types of changes
Checklist