fix(core-transaction-pool): check against tx network byte if set

[spkjp]

Proposed changes

The transaction network byte is useless as of now, because even if it is set, it does not prevent a tx from entering the pool if it doesn't match. Thus the transaction network byte is now checked against the pubKeyHash. If it doesn't match the transaction will be refused. Same for the Joi schema.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (improve a current implementation without adding a new feature or fixing a bug)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Build (changes that affect the build system)
• Docs (documentation only changes)
• Test (adding missing tests or fixing existing tests)
• Other... Please describe:

Checklist

• I have read the CONTRIBUTING documentation
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[codecov-io]

Codecov Report

Merging #1853 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1853      +/-   ##
===========================================
+ Coverage    39.21%   39.28%   +0.06%     
===========================================
  Files          350      350              
  Lines         7604     7609       +5     
  Branches      1104     1109       +5     
===========================================
+ Hits          2982     2989       +7     
+ Misses        4609     4606       -3     
- Partials        13       14       +1

Impacted Files	Coverage Δ
packages/crypto/src/validation/engine.ts	87.5% <ø> (ø)	⬆️
packages/crypto/src/managers/config.ts	97.72% <ø> (ø)	⬆️
...pto/src/validation/extensions/transactions/base.ts	100% <100%> (ø)	⬆️
...ges/crypto/src/builder/transactions/transaction.ts	93.93% <100%> (ø)	⬆️
packages/core-transaction-pool/src/guard.ts	89.69% <100%> (+2.45%)	⬆️
packages/core-logger-winston/src/formatter.ts	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a19547...db40d74. Read the comment docs.