chore: export core-logger-winston types.#1887
Merged
faustbrian merged 3 commits intoArkEcosystem:developfrom Dec 20, 2018
paroxysm:feat/export-core-logger-winston-types
Merged
chore: export core-logger-winston types.#1887faustbrian merged 3 commits intoArkEcosystem:developfrom paroxysm:feat/export-core-logger-winston-types
faustbrian merged 3 commits intoArkEcosystem:developfrom
paroxysm:feat/export-core-logger-winston-types
Conversation
faustbrian
reviewed
Dec 20, 2018
| * @return {void} | ||
| */ | ||
| public abstract printTracker(title: string, current: number, max: number, postTitle: string, figures: number): void; | ||
| public abstract printTracker( |
Contributor
There was a problem hiding this comment.
Did tslint format it like that?
Contributor
There was a problem hiding this comment.
Odd, never yet complained to me about that line.
Contributor
Author
There was a problem hiding this comment.
Yes it is...But I've noticed my IDE doesn't complain about max-len violations..
However, yarn test call does a yarn lint && yarn build before running tests which fixes such issues.
Contributor
Author
There was a problem hiding this comment.
core-logger-winston's logger.ts is unaffected because it just barely meets the length requirement.
faustbrian
approved these changes
Dec 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further addresses #1795. While we're exporting the
Loggertype defined in this module. The rest of the modules will only depend oncore-loggermodule for itsAbstractLoggertype. This ensures that, even though we're introducing acore-loggerdependency to all modules that need to log(so as to benefit from type-safety), we still retain the ability to supplant thecore-logger-winstonimplementation with a different implementation as long as that implementation extends fromcore-logger'sAbstractLoggeri.e. Override the winston logger with a logstash json encoded logger or RDMS logger or even a network streaming logger. As long as all these extend from the
AbstractLoggerincore-loggermodule, they still benefit from the type-safety but don't restrict the rest of the modules to one specific implementation.Types of changes
Checklist