refactor(core-p2p): network state quorum calculation#1898
Merged
faustbrian merged 22 commits intoArkEcosystem:developfrom Jan 3, 2019
spkjp:network-state
Merged
refactor(core-p2p): network state quorum calculation#1898faustbrian merged 22 commits intoArkEcosystem:developfrom spkjp:network-state
faustbrian merged 22 commits intoArkEcosystem:developfrom
spkjp:network-state
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1898 +/- ##
==========================================
- Coverage 40.52% 40.4% -0.12%
==========================================
Files 350 350
Lines 7569 7626 +57
Branches 1138 1147 +9
==========================================
+ Hits 3067 3081 +14
- Misses 4487 4530 +43
Partials 15 15
Continue to review full report at Codecov.
|
paroxysm
reviewed
Dec 24, 2018
vasild
previously requested changes
Dec 28, 2018
faustbrian
previously approved these changes
Jan 2, 2019
Contributor
|
@supaiku0 conflicts |
faustbrian
reviewed
Jan 3, 2019
| class QuorumDetails { | ||
| public getQuorum() { | ||
| const quorum = this.peersQuorum / (this.peersQuorum + this.peersNoQuorum); | ||
| return isNaN(quorum) ? 0 : quorum; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vasild
previously approved these changes
Jan 3, 2019
faustbrian
approved these changes
Jan 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactors the quorum calculation to keep track of the entire state. This should help pinpointing why the quorum sometimes randomly fails for no apparent reason.
Info dump when quorum fails:
Types of changes
Checklist