Skip to content

Export and use core-database typedefs#1901

Merged
faustbrian merged 3 commits intoArkEcosystem:developfrom
paroxysm:feat/export-core-database-typedefs
Dec 24, 2018
Merged

Export and use core-database typedefs#1901
faustbrian merged 3 commits intoArkEcosystem:developfrom
paroxysm:feat/export-core-database-typedefs

Conversation

@paroxysm
Copy link
Copy Markdown
Contributor

@paroxysm paroxysm commented Dec 23, 2018

Proposed changes

Closes #1790
I'll need to do another pass-through for these classes because we're not using access-modifiers/getter/setters properly.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@faustbrian faustbrian self-requested a review December 23, 2018 03:31
@faustbrian faustbrian merged commit 6466030 into ArkEcosystem:develop Dec 24, 2018
@paroxysm paroxysm deleted the feat/export-core-database-typedefs branch December 24, 2018 19:46
@paroxysm
Copy link
Copy Markdown
Contributor Author

paroxysm commented Dec 24, 2018

@faustbrian this didn't appear to auto-close the issue. Am I doing it wrong?
EDIT: Just read that page again, it says when it's pulled into the "default" branch of the repo, Which is master, not develop. So I guess all those issues will automatically close when develop is merged into master 👍

@alexbarnsley
Copy link
Copy Markdown
Member

Try "close #1790". I use "resolves #1790". I am surprised "closes" didn't work though, unless you added that after the PR was merged

@paroxysm
Copy link
Copy Markdown
Contributor Author

I had it in there when I created the PR, I think it's because "develop" isn't the default branch, "master" is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants