Export and use core-transaction-pool typedefs#1906
Merged
faustbrian merged 8 commits intoArkEcosystem:developfrom Dec 26, 2018
paroxysm:feat/export-core-transaction-pool-typedefs
Merged
Export and use core-transaction-pool typedefs#1906faustbrian merged 8 commits intoArkEcosystem:developfrom paroxysm:feat/export-core-transaction-pool-typedefs
faustbrian merged 8 commits intoArkEcosystem:developfrom
paroxysm:feat/export-core-transaction-pool-typedefs
Conversation
refactor: Remove un-used SPV.connection property refactor: Remove ConnectionInterface.connection property. This available in the 'options' object that's passed via constructor. refactor: Use inline-initialization instead of constructor initialization for concise code, unless we're accessing constructor parameters.
refactor: more inline-initialization vs constructor refactor: Removed some redundant vars in core-api Repositories, use inherited references instead.
…core-database-postgres-typedefs # Conflicts: # packages/core-database-postgres/src/connection.ts # packages/core-database-postgres/src/index.ts # packages/core-database-postgres/src/spv.ts # packages/core-database/src/interface.ts # packages/core-database/src/manager.ts
Contributor
|
@paroxysm conflicts |
faustbrian
reviewed
Dec 25, 2018
Contributor
Author
|
I'll address the conflicts when I get home later on today... |
…core-transaction-pool-typedefs # Conflicts: # packages/core-api/src/repositories/repository.ts # packages/core-blockchain/src/blockchain.ts # packages/core-graphql/src/repositories/repository.ts # packages/core-p2p/src/server/versions/1/handlers.ts # packages/core-transaction-pool/__tests__/connection.test.ts # packages/core-transaction-pool/__tests__/guard.test.ts
faustbrian
approved these changes
Dec 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
resolves #1793
I excluded core-test-utils because adding a dependency a
core-transaction-poolcreates a circular dependency becausecore-test-utilsis a devDependency on a couple of other modules(includingcore-transaction-poolitself)Types of changes
Checklist