refactor(crypto): export type definitions#1917
Merged
faustbrian merged 3 commits intoArkEcosystem:developfrom Dec 30, 2018
paroxysm:feat/export-crypto-typedefs
Merged
refactor(crypto): export type definitions#1917faustbrian merged 3 commits intoArkEcosystem:developfrom paroxysm:feat/export-crypto-typedefs
faustbrian merged 3 commits intoArkEcosystem:developfrom
paroxysm:feat/export-crypto-typedefs
Conversation
refactor: Simply imports
Contributor
|
@paroxysm you need to restart your CircleCI build because it failed |
faustbrian
approved these changes
Dec 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #1792
This PR simply exposes the types in crypto, but it doesn't propagate those types around their dependencies. The code-base is already using these types already.
The next step would be to improve type-safety, replacing a lot of 'any' with their actual expected types. This will require a lot more effort because it'll start introducing compile errors all over :)
Types of changes