refactor(core-api): implement a cache service to DRY the server method logic#1930
Merged
faustbrian merged 2 commits intodevelopfrom Jan 3, 2019
Merged
refactor(core-api): implement a cache service to DRY the server method logic#1930faustbrian merged 2 commits intodevelopfrom
faustbrian merged 2 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1930 +/- ##
===========================================
+ Coverage 39.83% 40.49% +0.66%
===========================================
Files 327 350 +23
Lines 7476 7561 +85
Branches 1120 1135 +15
===========================================
+ Hits 2978 3062 +84
+ Misses 4485 4484 -1
- Partials 13 15 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1930 +/- ##
===========================================
+ Coverage 39.83% 40.49% +0.65%
===========================================
Files 327 350 +23
Lines 7476 7562 +86
Branches 1120 1108 -12
===========================================
+ Hits 2978 3062 +84
Misses 4485 4485
- Partials 13 15 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
While looking into an issue in core-api I noticed that the server method cache could need some cleanup.
Types of changes
Checklist