fix(core-blockchain): port slot check from master#1985
Merged
faustbrian merged 6 commits intoArkEcosystem:developfrom Jan 16, 2019
spkjp:backport-slot-check
Merged
fix(core-blockchain): port slot check from master#1985faustbrian merged 6 commits intoArkEcosystem:developfrom spkjp:backport-slot-check
faustbrian merged 6 commits intoArkEcosystem:developfrom
spkjp:backport-slot-check
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1985 +/- ##
===========================================
+ Coverage 38.74% 38.83% +0.08%
===========================================
Files 375 376 +1
Lines 8199 8215 +16
Branches 1145 1150 +5
===========================================
+ Hits 3177 3190 +13
- Misses 5010 5013 +3
Partials 12 12
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Ports the slot check from #1974 to TypeScript.
Unfortunately, devnet needs some new block exceptions and in this case the checks have to be performed in multiple places. So I refactored how we handle such blocks. Now the
BlockProcessorwill return a new block handler to handle them separately.Managed to sync my devnet node from
1206609onwards up to current height. It is possible that there are a few bad blocks below that height.Types of changes
Checklist