Skip to content

fix(core-transaction-pool): increase max transaction age to 6 hours#1996

Merged
faustbrian merged 1 commit intoArkEcosystem:developfrom
spkjp:increase-max-tx-age
Jan 17, 2019
Merged

fix(core-transaction-pool): increase max transaction age to 6 hours#1996
faustbrian merged 1 commit intoArkEcosystem:developfrom
spkjp:increase-max-tx-age

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented Jan 17, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested a review from faustbrian January 17, 2019 14:21
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1996 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1996   +/-   ##
========================================
  Coverage    70.03%   70.03%           
========================================
  Files          385      385           
  Lines         8311     8311           
  Branches      1205     1185   -20     
========================================
  Hits          5821     5821           
- Misses        2453     2454    +1     
+ Partials        37       36    -1
Impacted Files Coverage Δ
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 38.88% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d43fe...da18f3c. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 17, 2019

Codecov Report

Merging #1996 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1996   +/-   ##
========================================
  Coverage    70.03%   70.03%           
========================================
  Files          385      385           
  Lines         8311     8311           
  Branches      1205     1185   -20     
========================================
  Hits          5821     5821           
- Misses        2453     2454    +1     
+ Partials        37       36    -1
Impacted Files Coverage Δ
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 38.88% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d43fe...da18f3c. Read the comment docs.

@faustbrian faustbrian merged commit c3ad02d into ArkEcosystem:develop Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants