Skip to content

fix(core-transaction-pool): disallow multiple registrations for same delegate#2080

Merged
faustbrian merged 1 commit intodevelopfrom
fix/delegate-pool
Feb 11, 2019
Merged

fix(core-transaction-pool): disallow multiple registrations for same delegate#2080
faustbrian merged 1 commit intodevelopfrom
fix/delegate-pool

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

@faustbrian faustbrian commented Feb 11, 2019

Proposed changes

Only allow a single instance of a delegate registration in the pool per address.
Closes: https://github.com/ArkEcosystem/security-vulnerabilities/blob/master/core/core-sv-012.md

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link
Copy Markdown

ghost commented Feb 11, 2019

@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested review from air1one and spkjp February 11, 2019 13:44
@faustbrian faustbrian merged commit 8399caa into develop Feb 11, 2019
@ghost ghost deleted the fix/delegate-pool branch February 11, 2019 13:46
@ghost ghost removed the Status: Needs Review label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants