Skip to content

fix(core-api): use the supply calculator in the v1 API#2083

Merged
j-a-m-l merged 1 commit intodevelopfrom
fix/supply
Feb 12, 2019
Merged

fix(core-api): use the supply calculator in the v1 API#2083
j-a-m-l merged 1 commit intodevelopfrom
fix/supply

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

Proposed changes

The v1 API was not using the supply calculator which caused a different result then the v2 API.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link
Copy Markdown

ghost commented Feb 12, 2019

@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested review from air1one and spkjp February 12, 2019 06:42
@ghost
Copy link
Copy Markdown

ghost commented Feb 12, 2019

@faustbrian The ci/circleci: test-node11-2 job is failing as of 7ceb13c8cc28b6a1b46906890c285895a10fa534. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 12, 2019

Codecov Report

Merging #2083 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2083      +/-   ##
===========================================
- Coverage    78.54%   78.54%   -0.01%     
===========================================
  Files          331      331              
  Lines         7742     7740       -2     
  Branches      1075     1066       -9     
===========================================
- Hits          6081     6079       -2     
  Misses        1630     1630              
  Partials        31       31
Impacted Files Coverage Δ
...kages/core-api/src/versions/1/blocks/controller.ts 60.86% <100%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5aafd...7ceb13c. Read the comment docs.

@j-a-m-l j-a-m-l merged commit 8c91440 into develop Feb 12, 2019
@ghost ghost deleted the fix/supply branch February 12, 2019 06:49
@ghost ghost removed the Status: Needs Review label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants