fix(core-api): use the supply calculator in the v1 API#2083
Merged
Conversation
|
@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
|
@faustbrian The ci/circleci: test-node11-2 job is failing as of 7ceb13c8cc28b6a1b46906890c285895a10fa534. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
j-a-m-l
approved these changes
Feb 12, 2019
Codecov Report
@@ Coverage Diff @@
## develop #2083 +/- ##
===========================================
- Coverage 78.54% 78.54% -0.01%
===========================================
Files 331 331
Lines 7742 7740 -2
Branches 1075 1066 -9
===========================================
- Hits 6081 6079 -2
Misses 1630 1630
Partials 31 31
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The v1 API was not using the supply calculator which caused a different result then the v2 API.
Types of changes
Checklist