fix(core-tester-cli): pass the base flags for programmatic calls#2108
Merged
faustbrian merged 3 commits intodevelopfrom Feb 18, 2019
Merged
fix(core-tester-cli): pass the base flags for programmatic calls#2108faustbrian merged 3 commits intodevelopfrom
faustbrian merged 3 commits intodevelopfrom
Conversation
|
@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
requested a review
from 
ghost
added
|
@faustbrian The ci/circleci: test-node11-2 job is failing as of 626bf36525d9c86988713234d948f17cb7013485. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #2108 +/- ##
========================================
Coverage 78.92% 78.92%
========================================
Files 330 330
Lines 7973 7973
Branches 1116 1114 -2
========================================
Hits 6293 6293
Misses 1648 1648
Partials 32 32Continue to review full report at Codecov.
|
faustbrian
changed the title
spkjp
approved these changes
Feb 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #2094
Types of changes
Checklist