fix(core-database): properly sort BigNumber values#2144
Merged
faustbrian merged 13 commits intodevelopfrom Feb 25, 2019
Merged
Conversation
|
@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
requested a review
from 
|
@faustbrian The ci/circleci: test-node11-0 job is failing as of 7c0ad74a7d6827cb26ce41914d6081b6afb6ef2a. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #2144 +/- ##
===========================================
- Coverage 79.48% 79.47% -0.02%
===========================================
Files 330 331 +1
Lines 7913 7922 +9
Branches 1099 1115 +16
===========================================
+ Hits 6290 6296 +6
- Misses 1590 1593 +3
Partials 33 33
Continue to review full report at Codecov.
|
faustbrian
changed the title
|
@faustbrian Your pull request doesn't have a test case, which is a requirement for it to be merged. Please provide it and one of the developers will review it before merging. |
faustbrian
changed the title
ghost
mentioned this pull request
spkjp
previously requested changes
Feb 25, 2019
| if (["balance", "voteBalance"].includes(iteratee)) { | ||
| return Object.values(entries).sort((a: any, b: any) => { | ||
| return order === "asc" | ||
| ? +a[iteratee].minus(b[iteratee]).toFixed() |
Contributor
There was a problem hiding this comment.
Use https://mikemcl.github.io/bignumber.js/#cmp for comparing BigNumbers.
|
@faustbrian Your pull request needs some changes. Please wait for a comment from one of our developers for more information. |
vasild
added a commit
that referenced
this pull request
Feb 27, 2019
* ArkEcosystem/core/2.3: chore: move core-graphql to the deprecated folder (#2169) refactor(crypto): benchmarks (#2167) refactor: replace micromatch with nanomatch and remove heavy deps (#2165) feat(crypto): increase vendor field length to 255 bytes (#2159) feat(core-api): search delegates by usernames (#2143) feat(core-logger-pino): initial implementation (#2134) perf(crypto): integrate bcrypto (#2158) feat(core): ask for process restarts after updating (#2155) refactor(core): replace pm2 with process manager (#2154) refactor(core): require the user to take action for updates (#2153) feat(core-p2p): Fetch list of peers from at least a few others (#2152) refactor(core): more robust check for ensureDefaults (#2151) fix(core): ensure file and defaults before reading fix(core): return correct suffix for core:restart command (#2150) fix(core-database): properly sort BigNumber values (#2144) feat(core): configuration and channel support for the CLI (#2145) feat(core): merge core-snapshot-cli commands into core (#2149) fix(core-api): pass query to findAllByVote method (#2142) feat(core-p2p): Validate GET replies from other peers (#2102) chore(release): 2.2.0-beta.7 (#2141) fix(core-blockchain): stuck at not ready to accept new block (#2139) refactor(core-p2p): Improve selection of peer for downloading blocks (#2137) fix(core): overwrite the config path if an env variable is provided (#2140) fix(core): do not ignore the network flag in parseWithNetwork (#2138) chore(release): 2.2.0-beta.6 (#2136) refactor(core-container): throw an error if the peers or plugins file are missing (#2135) chore(release): 2.2.0-beta.5 (#2132) refactor(core-p2p): reduce logging noise (#2129) misc(core-p2p): remove superfluous log message (#2128) refactor(core-p2p): Improve fork handling in updatePeersOnMissingBlocks (#2125)
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
BigNumbervalues were sorted but resulted in an odd order.Types of changes
Checklist