fix(core-snapshots): reset unfinished round after import#2486
Merged
faustbrian merged 3 commits intoArkEcosystem:masterfrom Apr 26, 2019
spkjp:snapshot-round-reset
Merged
fix(core-snapshots): reset unfinished round after import#2486faustbrian merged 3 commits intoArkEcosystem:masterfrom spkjp:snapshot-round-reset
faustbrian merged 3 commits intoArkEcosystem:masterfrom
spkjp:snapshot-round-reset
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2486 +/- ##
==========================================
- Coverage 66.1% 66.07% -0.03%
==========================================
Files 400 400
Lines 8611 8614 +3
Branches 435 436 +1
==========================================
Hits 5692 5692
- Misses 2874 2877 +3
Partials 45 45
Continue to review full report at Codecov.
|
vasild
added a commit
that referenced
this pull request
Apr 26, 2019
…tion-expiration-in-height * ArkEcosystem/core/develop: fix(core): parse only the last line of pm2 stdout (#2484) release: 2.3.18 (#2488) fix(core-snapshots): reset unfinished round after import (#2486) fix(core-forger): update configManager height (#2487) release: 2.3.16 (#2483) fix(core-database): initialize height on startup (#2482)
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the snapshot manager finishes an import it is supposed to reset an unfinished round by default, but because we passed the wrong parameter it stopped working.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
Checklist