fix(core-json-rpc): avoid getting stuck on a unresponsive peer by picking a random one each time#2491
Merged
faustbrian merged 1 commit intomasterfrom Apr 30, 2019
Merged
Conversation
|
The ci/circleci: test-node11-integration-0 job is failing as of b813ef8bdaaf298f2bbf67a3db96002975434cd4. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #2491 +/- ##
==========================================
+ Coverage 66.07% 66.11% +0.03%
==========================================
Files 400 400
Lines 8614 8602 -12
Branches 436 436
==========================================
- Hits 5692 5687 -5
+ Misses 2877 2870 -7
Partials 45 45
Continue to review full report at Codecov.
|
spkjp
approved these changes
Apr 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Select a random peer every time we send a request and try to do so up to 3 times before giving up.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
Checklist