Skip to content

fix(core-p2p): accept requests to /transactions regardless of suspension#2503

Merged
faustbrian merged 1 commit intoArkEcosystem:masterfrom
spkjp:relax-post-ban
Apr 30, 2019
Merged

fix(core-p2p): accept requests to /transactions regardless of suspension#2503
faustbrian merged 1 commit intoArkEcosystem:masterfrom
spkjp:relax-post-ban

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented Apr 29, 2019

Summary

This is giving relays with closed p2p ports a hard time broadcasting transactions. Therefore it's best to accept incoming /transactions POST requests.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2503 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2503   +/-   ##
=======================================
  Coverage   66.07%   66.07%           
=======================================
  Files         400      400           
  Lines        8614     8614           
  Branches      436      395   -41     
=======================================
  Hits         5692     5692           
- Misses       2877     2878    +1     
+ Partials       45       44    -1
Impacted Files Coverage Δ
...ages/core-p2p/src/server/plugins/accept-request.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74ec6a...47c6247. Read the comment docs.

@faustbrian faustbrian merged commit 5116229 into ArkEcosystem:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants