fix(core-api): return transaction timestamp instead of block timestamp#2513
Merged
faustbrian merged 1 commit intoArkEcosystem:masterfrom May 2, 2019
spkjp:api-tx-timestamp
Merged
fix(core-api): return transaction timestamp instead of block timestamp#2513faustbrian merged 1 commit intoArkEcosystem:masterfrom spkjp:api-tx-timestamp
faustbrian merged 1 commit intoArkEcosystem:masterfrom
spkjp:api-tx-timestamp
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2513 +/- ##
==========================================
- Coverage 66.02% 66.01% -0.01%
==========================================
Files 400 400
Lines 8617 8616 -1
Branches 437 395 -42
==========================================
- Hits 5689 5688 -1
- Misses 2883 2884 +1
+ Partials 45 44 -1
Continue to review full report at Codecov.
|
faustbrian
approved these changes
May 2, 2019
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2513 +/- ##
==========================================
- Coverage 66.02% 66.01% -0.01%
==========================================
Files 400 400
Lines 8617 8616 -1
Branches 437 395 -42
==========================================
- Hits 5689 5688 -1
- Misses 2883 2884 +1
+ Partials 45 44 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Always return the transaction timestamp instead of preferring the block timestamp so that a transaction can be properly verified. Only changed the v2 endpoint, since the v1 endpoint is deprecated anyway.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
Checklist