Skip to content

fix(core-api): return transaction timestamp instead of block timestamp#2513

Merged
faustbrian merged 1 commit intoArkEcosystem:masterfrom
spkjp:api-tx-timestamp
May 2, 2019
Merged

fix(core-api): return transaction timestamp instead of block timestamp#2513
faustbrian merged 1 commit intoArkEcosystem:masterfrom
spkjp:api-tx-timestamp

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented May 1, 2019

Summary

Always return the transaction timestamp instead of preferring the block timestamp so that a transaction can be properly verified. Only changed the v2 endpoint, since the v1 endpoint is deprecated anyway.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested review from faustbrian and kristjank as code owners May 1, 2019 20:28
@ghost ghost added Complexity: Low labels May 1, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2513 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
- Coverage   66.02%   66.01%   -0.01%     
==========================================
  Files         400      400              
  Lines        8617     8616       -1     
  Branches      437      395      -42     
==========================================
- Hits         5689     5688       -1     
- Misses       2883     2884       +1     
+ Partials       45       44       -1
Impacted Files Coverage Δ
...ore-api/src/versions/2/transactions/transformer.ts 100% <ø> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1259327...423241b. Read the comment docs.

@faustbrian faustbrian merged commit 2748ecc into ArkEcosystem:master May 2, 2019
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.01%. Comparing base (1259327) to head (423241b).
⚠️ Report is 2177 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
- Coverage   66.02%   66.01%   -0.01%     
==========================================
  Files         400      400              
  Lines        8617     8616       -1     
  Branches      437      395      -42     
==========================================
- Hits         5689     5688       -1     
- Misses       2883     2884       +1     
+ Partials       45       44       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants